From 7f243c6a301fbb6cd559ef628bf76f73e86bd612 Mon Sep 17 00:00:00 2001 From: Arpad Ryszka Date: Fri, 27 Oct 2017 16:04:09 +0200 Subject: [PATCH] add notes --- choice.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/choice.go b/choice.go index 2ef334d..8579fec 100644 --- a/choice.go +++ b/choice.go @@ -193,7 +193,10 @@ func (p *choiceParser) parse(t Trace, c *context) { foundMatch = false elementIndex = 0 - // TODO: avoid double parsing by setting first-from-store in the context + // TODO: + // - avoid double parsing by setting first-from-store in the context, prepare in advance to + // know whether it can be it's own item + // - it is also important to figure why disabling the failed elements breaks the parsing for elementIndex < len(p.elements) { p.elements[elementIndex].parse(t, c)