arpio/treerack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor - remove stale TODOs

Browse Source
This commit is contained in:
Arpad Ryszka 2017-11-04 22:58:43 +01:00
parent 446022c546
commit b640b60ba9
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
choice.go
View File

@ -160,11 +160,6 @@ func (p *choiceParser) parse(c *context) {
foundMatch = false foundMatch = false
optionIndex = 0 optionIndex = 0
// TODO:
// - avoid double parsing by setting first-from-store in the context, prepare in advance to
// know whether it can be it's own item
// - it is also important to figure why disabling the failed options breaks the parsing
for optionIndex < len(p.options) { for optionIndex < len(p.options) {
p.options[optionIndex].parse(c) p.options[optionIndex].parse(c)
optionIndex++ optionIndex++

1
sequence.go
View File

@ -192,7 +192,6 @@ func (p *sequenceParser) parse(c *context) {
var parsed bool var parsed bool
for itemIndex < len(p.items) { for itemIndex < len(p.items) {
// TODO: test this f(g())
p.items[itemIndex].parse(c) p.items[itemIndex].parse(c)
if !c.matchLast { if !c.matchLast {
if currentCount < p.ranges[itemIndex][0] { if currentCount < p.ranges[itemIndex][0] {